Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication support #12

Closed
Shadowfaxenator opened this issue Nov 21, 2013 · 17 comments
Closed

Authentication support #12

Shadowfaxenator opened this issue Nov 21, 2013 · 17 comments

Comments

@Shadowfaxenator
Copy link

When an authentication will be supported like it is in angularFire?

@mikeboydbrowne
Copy link

You can see an example of a sample authentication system at https://github.com/balinterdi/ideavote-emberfire

@anantn
Copy link
Contributor

anantn commented Jan 7, 2014

We don't plan on adding authentication support in the immediate future, though it is on the roadmap. You can always directly use the Firebase auth API or Simple Login directly.

@anantn anantn closed this as completed Jan 8, 2014
@katowulf
Copy link
Contributor

katowulf commented Jan 9, 2014

@mikeboydbrowne thanks for the great example! It looks like it should be rather helpful for other users until we have auth baked in. Cheers!

@davecyen
Copy link

An integrated auth or tutorial on how to use Simple Login with EmberFire would be awesome!

@stefanpenner
Copy link
Collaborator

I recently code-reviewed @raytiley's version of this, maybe he is able to share.

@anantn
Copy link
Contributor

anantn commented Feb 17, 2014

Re-opening issue, so we can target this feature in the next couple of release cycles.

@raytiley
Copy link

Still a work in progress but people are welcome to glean what info they can from it: https://gist.github.com/raytiley/8976037

This controller is kinda tied to the way I want my app to work (it automatically creates a new ember data User when creating a new user). I'll probably refactor that out.

The big gotcha with the SimpleLogin stuff is that you have a single callback that gets fired every time user state changes. This makes it tricky to wrap things like logging in and logging out with a Promise which would feel more Emberish, especially when checking things like login state via promise aware router hooks.

I can give more feedback later if needed.

@hayd
Copy link

hayd commented Jun 24, 2014

I think this would be really useful as a custom generator for ember-cli!

This Stack Overflow question is also related: http://stackoverflow.com/questions/21084013/implement-firebase-simplelogin-email-password-in-ember-js-app

@davidpett
Copy link

Since authentication is now in firebase core, is there plan to add this functionality to emberFire?

@katowulf
Copy link
Contributor

Authentication being added to the core doesn't make it any simpler to implement in Ember. As mentioned before, it's something that is definitely on our radar (this issue is still open). As we grow the team, we'll look into this. In the mean time, use the example from @mikeboydbrowne and build from there.

@davidpett
Copy link

@katowulf, thanks for the reply, I'm working on an initializer now that might be helpful, if it gets to a good point, I will submit a PR

@sararob
Copy link
Contributor

sararob commented Nov 14, 2014

@Shadowfaxenator I'm closing this issue since it's a duplicate of #111. We'll work on adding support for authentication in upcoming releases.

@sararob sararob closed this as completed Nov 14, 2014
@oskarrough
Copy link
Contributor

I have a working authentication Firebase Auth and Emberfire. Some hoops but stable for 2-3 weeks now. Will see if I can publish it somehow.

@sararob
Copy link
Contributor

sararob commented Nov 15, 2014

@oskarrough awesome! Feel free to share when it's ready and I'll take a look

@oskarrough
Copy link
Contributor

@davidpett @sararob here we go: https://gist.github.com/oskarrough/914653b03d886c015320

I added some excessive commenting to the gist with the hope we can make it better together.

@davidpett
Copy link

@oskarrough looks very similar to what I have. I will fork this and add in the authWithPassword since that is what I'm using in my app. Great work!

@hayd
Copy link

hayd commented Nov 16, 2014

@oskarrough Thanks for posting that!

I wonder if it's worth/makes sense tweaking that into a fully-fledged ember-cli addon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests