Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isNumber not defined in IE #545

Closed
mival opened this issue Feb 12, 2018 · 0 comments
Closed

isNumber not defined in IE #545

mival opened this issue Feb 12, 2018 · 0 comments

Comments

@mival
Copy link

mival commented Feb 12, 2018

Version info

DEBUG: -------------------------------
DEBUG: Ember      : 2.18.0
DEBUG: Ember Data : 2.18.0
DEBUG: Firebase   : 3.9.0
DEBUG: EmberFire  : 0.0.0 (2.0.9 from package.json)
DEBUG: jQuery     : 3.3.1
DEBUG: -------------------------------

Test case

Open emberfire project in IE 11.

Steps to reproduce

Open emberfire project in IE 11. When making store query on emberfire it crash.

Expected behavior

It should not crash

Actual behavior

It crash on isInteger call, https://github.com/firebase/emberfire/blob/master/addon/adapters/firebase.js#L323

I suggest add polyfill for isInteger https://developer.mozilla.org/cs/docs/Web/JavaScript/Reference/Global_Objects/Number/isInteger#Polyfill
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mival