Refactor the adapter, tests and build process, upgrade to ED 10 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to Ember-Data beta.10 The adapter event subscribing to Firebase events now lives in the afterPush hook instead of being scattered around the adapter. Embedded processing has been refactored to recursively normalize embedded records, bringing it more in line with the EmbeddedRecordsMixin(maybe we should use it at some point), simplyfying the code and fixing several embedded related bugs. Tests are now more functional allowing for easier refactors. Tests have been refactored, for easier reading/writing and less interdependence. Lots of new tests added Grunt now watches for changes and rebuilds correctly Various other fixes, refactors and cleanups. fixes FirebaseExtended#129 fixes FirebaseExtended#103 fixes FirebaseExtended#124 fixes FirebaseExtended#121 fixes FirebaseExtended#94 fixes FirebaseExtended#88 should also fix, but lacking tests for FirebaseExtended#114 FirebaseExtended#96 FirebaseExtended#59 FirebaseExtended#44
|
|
||
| recordWillUnload: function(store, record) { | ||
| var ref = this._getRef(record.typeKey, record.get('id')); | ||
| ref.off('value'); |
There was a problem hiding this comment.
Might be good to pass the callback here as well in case the user happened to attach a listener to this location outside of EmberFire (calling ref.off() with no callback removes all listeners at a location)
ref.off('value', theCallbackThatWasUsed)
|
All the tests pass when using Firebase 1.1.0! I can also confirm that this fixes #114. Once this is merged in, I'd be happy to update the example to the latest versions as well, and fix the few small things that have changed in the Ember Data API since then. |
sararob
added a commit
that referenced
this pull request
Oct 7, 2014
Refactor the adapter, tests and build process, upgrade to ED 10
This was referenced Dec 10, 2014
This was referenced Apr 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Ember-Data beta.10
The adapter event subscribing to Firebase events now lives
in the afterPush hook instead of being scattered around the adapter.
Embedded processing has been refactored to recursively normalize embedded
records, bringing it more in line with the EmbeddedRecordsMixin(maybe we should
use it at some point), simplyfying the code and fixing several embedded related
bugs.
Tests are now more functional allowing for easier refactors.
Tests have been refactored, for easier reading/writing and less
interdependence.
Lots of new tests added
Grunt now watches for changes and rebuilds correctly
Various other fixes, refactors and cleanups.
fixes #129 fixes #103 fixes #124 fixes #121 fixes #94
should also fix, but lacking tests for #114 #96 #59