Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #484 acceptance tests fail #499

Merged

Conversation

tsubik
Copy link
Contributor

@tsubik tsubik commented Apr 13, 2017

Description

This PR address problem with failing acceptance tests #484. Every third-party event handler should be executed within the context of new Ember run-loop instance. This reverts #481, so if the root cause of mentioned PR still occurs, we need to address the problem differently.

Copy link
Contributor

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesdaniels jamesdaniels merged commit 355fb99 into FirebaseExtended:master Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants