Fix intermittent CI build failures and add basic Angular functional tests #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdaniels
requested review from
a team,
Yuangwang,
sjjj986 and
leoortizz
as code owners
Yuangwang
reviewed
May 16, 2024
jamesdaniels
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+23
to
+25
| app.get("*", (request, response) => { | ||
| response.sendFile(path.join(__dirname, "..", "browser", "index.html")); | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
There was a problem hiding this comment.
Since this is a static, single file, not dynamic we can probably ignore this if express caches; else we should read into memory.
jamesdaniels
changed the title
jamesdaniels
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something about the lru types is very broken ATM (see the build result of #190, #191, etc.), from local error messages it seems that they are passthrough now and not required... but that conflicts with the linked logs. Very flaky, regardless, this all seems to resolve on an NPM install and on CI we are skipping that on an NPM cache hit. IMO we should just call
npm cieverytime right now, until we can figure out why the NPM cache step is insufficient / flaking.While I was working on reproducing this I noted that the way we were packing adapter-angular/simple-server was also confusing things (see run #9114734835), so I took a pass on fixing that.
npm cirun even on npm cache hit