Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent CI build failures and add basic Angular functional tests #193

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ jobs:
restore-keys: |
${{ runner.os }}-20-
- name: Install deps
if: steps.node_modules_cache.outputs.cache-hit != 'true'
run: npm ci
- name: Build
run: npm run build
Expand Down
60 changes: 35 additions & 25 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion packages/@apphosting/adapter-angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"type": "module",
"sideEffects": false,
"scripts": {
"build": "rm -rf dist && tsc && chmod +x ./dist/bin/*",
"build": "rm -rf dist && tsc && rollup -c --silent && chmod +x ./dist/bin/*",
"test": "ts-mocha -p tsconfig.json src/**/*.spec.ts"
},
"exports": {
Expand Down Expand Up @@ -59,6 +59,12 @@
}
},
"devDependencies": {
"@rollup/plugin-json": "^6.1.0",
"express": "^4.18.2",
"rollup": "^4.12.0",
"@rollup/plugin-node-resolve": "^15.2.3",
"rollup-plugin-commonjs": "^10.1.0",
"rollup-plugin-node-resolve": "^5.2.0",
"@angular-devkit/architect": "~0.1702.0",
"@angular-devkit/core": "~17.2.0",
"@angular/core": "~17.2.0",
Expand Down
12 changes: 12 additions & 0 deletions packages/@apphosting/adapter-angular/rollup.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import resolve from "@rollup/plugin-node-resolve";
import json from "@rollup/plugin-json";
import commonjs from "rollup-plugin-commonjs";

export default {
input: "./dist/simple-server/server.js",
output: {
file: "./dist/simple-server/bundled_server.mjs",
jamesdaniels marked this conversation as resolved.
Show resolved Hide resolved
format: "es",
},
plugins: [resolve({ preferBuiltins: true }), json(), commonjs()],
};
Loading
Loading