Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cloud_firestore] Fix broken __NSCFBoolean conversion always resulting in TRUE (iOS only) #1407

Merged
merged 2 commits into from
Jan 23, 2020
Merged

[cloud_firestore] Fix broken __NSCFBoolean conversion always resulting in TRUE (iOS only) #1407

merged 2 commits into from
Jan 23, 2020

Conversation

mono0926
Copy link
Contributor

@mono0926 mono0926 commented Nov 12, 2019 •
edited
Loading

Description

Previously, it was always true even though set to false.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).

It is hard to write test for this changes.
Similar pull requests like #98 doesn't include test, so I'd like you to approve this without any tests.

@mono0926
Copy link
Contributor Author

There are some errors, but those seem to be not related to this change.

@mono0926
Fix bool argument handling
5828619 
- Previously, it was always `true` even though set to `false`
@mono0926
Update CHANGELOG
6fc2896
@mono0926
Copy link
Contributor Author

@kroikie
Could you review this?
I'm waiting for 2 months so far.

@kroikie kroikie merged commit f440b87 into firebase:master Jan 23, 2020
@kroikie
Copy link
Collaborator

kroikie commented Jan 23, 2020

@mono0926 Sorry for the delay, thanks for the PR.

@mono0926 mono0926 deleted the fix-firestore-ios-settings branch February 5, 2020 10:08
@mono0926
Copy link
Contributor Author

mono0926 commented Feb 5, 2020

@collinjackson @kroikie

Could you release this?
https://pub.dev/packages/cloud_firestore

@firebase firebase locked and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@collinjackson collinjackson collinjackson approved these changes

@kroikie kroikie kroikie approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mono0926 @kroikie @collinjackson @googlebot