[firebase_ml_vision] v2 embedding API #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
reviewed
Oct 8, 2019
bparrishMines
commented
Oct 9, 2019
| shimPluginRegistry.registrarFor("io.flutter.plugins.pathprovider.PathProviderPlugin")); | ||
| ImagePickerPlugin.registerWith( | ||
| shimPluginRegistry.registrarFor("io.flutter.plugins.imagepicker.VideoPlayerPlugin")); | ||
| // CameraPlugin.registerWith( |
There was a problem hiding this comment.
This is commented out because the CameraPlugin requires an v1 embedding FlutterView. This prevented the example app from running, but shouldn't affect the plugin dependencies.
|
LGTM |
| @@ -0,0 +1,46 @@ | |||
| import 'dart:io'; | |||
There was a problem hiding this comment.
I think you meant to name this firebase_ml_vision_e2e.dart
There was a problem hiding this comment.
Yea I noticed that was one of the problems that caused the failing test. I fixed it in #1363
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes flutter/flutter#41875
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?