-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[firebase_ml_vision] v2 embedding API #275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with everything other than the activity renaming in the example app.
shimPluginRegistry.registrarFor("io.flutter.plugins.pathprovider.PathProviderPlugin")); | ||
ImagePickerPlugin.registerWith( | ||
shimPluginRegistry.registrarFor("io.flutter.plugins.imagepicker.VideoPlayerPlugin")); | ||
// CameraPlugin.registerWith( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is commented out because the CameraPlugin
requires an v1 embedding FlutterView
. This prevented the example app from running, but shouldn't affect the plugin dependencies.
LGTM |
@@ -0,0 +1,46 @@ | |||
import 'dart:io'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you meant to name this firebase_ml_vision_e2e.dart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I noticed that was one of the problems that caused the failing test. I fixed it in #1363
Description
Fixes flutter/flutter#41875
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?