Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_remote_config] Add macOS support #2889

Closed
wants to merge 5 commits into from

Conversation

davcannon
Copy link

Description

Adds macOS support to the firebase_remote_config plugin

Related Issues

Fixes #2697, also related to #1653

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@kroikie
Copy link
Collaborator

kroikie commented Jul 3, 2020

@balconywood thanks for the PR! Before we can support macos we should move the Remote Config Plugin to platform interface. I would be happy to review a PR that does that then look at adding different platform support. Would you be interested in providing a platform interface implementation for Remote Config?

@davcannon
Copy link
Author

@kroikie Sure, I'll see what I can do

@Salakar
Copy link
Member

Salakar commented Jul 31, 2020

MacOS support for Remote Config has landed on master from another PR of mine and a pre-release is available, so I'm going to go ahead and close this PR, sorry 🙈 thanks for contributing though!

https://firebase.flutter.dev/docs/remote-config/overview

@Salakar Salakar closed this Jul 31, 2020
@firebase firebase locked and limited conversation to collaborators Aug 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[remote_config] macOS Support
4 participants