Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AppCheck, Analytics, and Functions sdks. #432

Closed
wants to merge 25 commits into from

Conversation

justjish
Copy link
Contributor

@justjish justjish commented Aug 26, 2021

Description

  • Create proposal issues for supporting Firebase Analytics, Firebase Functions, and allowing 'dist' to exist in svn.
  • Add useInitAppCheck useAppCheck AppCheckProvider
  • Add useInitAnalytics useAnalytics AnalyticsProvider
  • Add useInitFunctions useFunctions FunctionsProvider
  • Add AppCheck examples for withSuspense and withoutSuspense
  • Add Analytics examples for withSuspense and withoutSuspense
  • Add Functions examples for withSuspense and withoutSuspense
  • Add Functions SDK Test? Maybe leave out of this PR
  • Allow for dist folder to exist in repo to allow users to use yarn add http://github.com/.../reactfire#[branch] ... todo produce build during pre-commit check?

Code Cleanup

  • RemoteConfig now uses rxfire for getValue, getString, getBoolean... rather than just having duplicate code.
  • Use objectVal from rxfire for database
  • Reference [api].sdk.app.name for all app name checks
  • Remove/Convert //@ts-ignore to //@ts-expect-error
  • Update firestore withSuspense example so that it doesn't spit out error @ runtime.
  • Update dev-dependencies to nearest non-breaking changes.

Code sample

[TODO]

@google-cla google-cla bot added the cla: yes label Aug 26, 2021
@jhuleatt
Copy link
Collaborator

Hi @sujishpatel thank you for your contribution! We really appreciate all of this work, but it is difficult for us to review a PR with so many different changes. Would you be up for breaking this apart into a few PRs and issues? My suggestion for breaking this into pieces is:

Individual PRs

Please file an issue for discussion

  • dist folder: Let's discuss and get @jamesdaniels input
  • Update firestore withSuspense example so that it doesn't spit out error @ runtime: can you please file an issue that describes the error?

Other

  • Use objectVal from rxfire for database: this was fixed here, so I don't think it is needed any more

Thank you again for your hard work! If you can break your changes out into multiple PRs, we'll get them reviewed and merged as quickly as possible.

@justjish
Copy link
Contributor Author

will do

@justjish justjish closed this Aug 27, 2021
@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants