-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AppCheck, Analytics, and Functions sdks. #432
Conversation
Hi @sujishpatel thank you for your contribution! We really appreciate all of this work, but it is difficult for us to review a PR with so many different changes. Would you be up for breaking this apart into a few PRs and issues? My suggestion for breaking this into pieces is: Individual PRs
Please file an issue for discussion
Other
Thank you again for your hard work! If you can break your changes out into multiple PRs, we'll get them reviewed and merged as quickly as possible. |
will do |
Description
useInitAppCheck
useAppCheck
AppCheckProvider
useInitAnalytics
useAnalytics
AnalyticsProvider
useInitFunctions
useFunctions
FunctionsProvider
dist
folder to exist in repo to allow users to useyarn add http://github.com/.../reactfire#[branch]
... todo produce build during pre-commit check?Code Cleanup
getValue, getString, getBoolean...
rather than just having duplicate code.objectVal
from rxfire for database//@ts-ignore
to//@ts-expect-error
Code sample
[TODO]