Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deadlock happens when running 'List Trace Sessions' service and there are many active trace sessions #8151

Closed
hvlad opened this issue Jun 5, 2024 · 2 comments
Closed

Deadlock happens when running 'List Trace Sessions' service and there are many active trace sessions #8151

hvlad opened this issue Jun 5, 2024 · 2 comments
Assignees
@hvlad
Labels
affect-version: 5.0.0 fix-version: 3.0.12 fix-version: 4.0.5 fix-version: 5.0.1 fix-version: 6.0 Alpha 1 type: bug

Comments

@hvlad
Copy link
Member

hvlad commented Jun 5, 2024

The bug was found when few instances of QA tests was running concurrently.

The stack trace is attached, look at threads 7 and 2

The problem happens when textual representation for list of trace sessions takes more than 1KB (internal size of service output buffer) and service working thread runs faster than service start thread fire EVENT_SERVICE_START.
@hvlad hvlad self-assigned this Jun 5, 2024
@hvlad hvlad added the type: bug label Jun 5, 2024
@hvlad hvlad changed the title Deadlock happens when one process run 'List Trace Sessions' service and there are many active trace sessions Deadlock happens when run 'List Trace Sessions' service and there are many active trace sessions Jun 5, 2024
hvlad added a commit that referenced this issue Jun 5, 2024
@hvlad
Fixed bug #8151 : Deadlock happens when run 'List Trace Sessions' ser…
fb83321 
…vice and there are many active trace sessions
@Noremos
Copy link
Contributor

Noremos commented Jun 7, 2024

Hello. I've noticed the findSession method does not check check if the slot is alive (used > 0) or not. Is it by design?

@hvlad
Copy link
Member Author

hvlad commented Jun 7, 2024

Hello. I've noticed the findSession method does not check check if the slot is alive (used > 0) or not. Is it by design?

Yes, by design. This is low-level routine that implements binary search, no more.
The caller intentions is not known here.

hvlad added a commit that referenced this issue Jun 8, 2024
@hvlad
Undone part of recent fix for #8151 as it prevents trace session from…
f713060 
… tracing own start as shown by failed QA tests:

tests\bugs\core_3168_test.py
tests\bugs\core_3658_test.py
tests\functional\services\test_role_in_service_attachment.py
hvlad added a commit that referenced this issue Jun 9, 2024
@hvlad
Fixed bug #8151 : Deadlock happens when run 'List Trace Sessions' ser…
9de13c6 
…vice and there are many active trace sessions
hvlad added a commit that referenced this issue Jun 9, 2024
@hvlad
Fixed bug #8151 : Deadlock happens when run 'List Trace Sessions' ser…
4a305f3 
…vice and there are many active trace sessions
hvlad added a commit that referenced this issue Jun 13, 2024
@hvlad
Re-implement fix for bug #8151 : Deadlock happens when run 'List Trac…
2de20ef 
…e Sessions' service and there are many active trace sessions
@hvlad hvlad closed this as completed Jun 13, 2024
@mrotteveel mrotteveel changed the title Deadlock happens when run 'List Trace Sessions' service and there are many active trace sessions Deadlock happens when running 'List Trace Sessions' service and there are many active trace sessions Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvlad hvlad

Labels
affect-version: 5.0.0 fix-version: 3.0.12 fix-version: 4.0.5 fix-version: 5.0.1 fix-version: 6.0 Alpha 1 type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hvlad @Noremos