Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit for imported rules does not work #101

Closed
crssi opened this issue Oct 27, 2018 · 10 comments
Closed

Edit for imported rules does not work #101

crssi opened this issue Oct 27, 2018 · 10 comments

Comments

@crssi
Copy link

crssi commented Oct 27, 2018

Firefox: 63 x64
Header Editor: 4.0.2
OS: Windows 10 x64
Addons: New profile with HE only

When rules are imported (Options -> Export and Import -> Download rule), then we cannot edit those rules anymore.

Additionally when clicked Edit button on one of imported rules (nothing happens) and after we click + the new rule is partially filled with data of the rules we prior clicked the Edit button.

Edit: Also when Clone is used, the new rule does not "happen".

Cheers

@sylingd
Copy link
Member

sylingd commented Oct 27, 2018

I have tested on firefox nightly and chrome, it works well. Please take a screenshot of Console (Press F12), maybe it is helpful.

@crssi
Copy link
Author

crssi commented Oct 27, 2018

When I click edit on FF63 nothing happens and the console throws out this:

TypeError: e.action is undefined[Learn More]      options.js:38:101620
onEditRule      moz-extension://addon_id/options/options.js:38:101620
onEditRule      self-hosted:974:17
click      moz-extension://addon_id/options/options.js:38:114665
t      moz-extension://addon_id/options/options.js:7:12128
sr/t</e._withTask      moz-extension://addon_id/options/options.js:7:41323

In upper text I have replaced long AddonID with addon_id.

Do you need a screenshot or upper info is good enough?

Cheers

@sylingd
Copy link
Member

sylingd commented Oct 27, 2018

It seems that this problem is related to the rules you imported. Can you give me the rules you imported?

@crssi
Copy link
Author

crssi commented Oct 27, 2018

Sure... here they are: https://raw.githubusercontent.com/crssi/Firefox/master/HeaderEditor.json

Thank you

@sylingd
Copy link
Member

sylingd commented Oct 28, 2018

The Header Editor has some problems dealing with custom functions, I have fixed them and will take effect in the next version

@crssi
Copy link
Author

crssi commented Oct 28, 2018

You are best 👍, thank you.
Please close this issue when appropriate for you.

Cheers

@sylingd
Copy link
Member

sylingd commented Oct 28, 2018

Thank you for your feedback

@sylingd sylingd closed this as completed Oct 28, 2018
@sylingd
Copy link
Member

sylingd commented Oct 29, 2018

I have released 4.0.3, please update to test

@crssi
Copy link
Author

crssi commented Oct 29, 2018 via email

@crssi
Copy link
Author

crssi commented Nov 6, 2018

It seems to be working now as intended.

Thank you @sylingd 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants