Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4 SnapshotGenerator: Fix ElementDefinition.Base for newly introduced elements #1053

Closed
wmrutten opened this issue Jul 23, 2019 · 1 comment
Closed

R4 SnapshotGenerator: Fix ElementDefinition.Base for newly introduced elements #1053

wmrutten opened this issue Jul 23, 2019 · 1 comment
Assignees
@wmrutten
Labels
bug

Comments

@wmrutten
Copy link
Contributor

Example: core StructureDefinition for Resource

  • Introduces element Resource.id (0...1, type=Id)
  • Inherits from Id StructureDefinition root element (0...*)

=> Initialize ElementDefinition.Base for path=Resource.id as:

Path = `Resource.id`
Min = 0
Max = 1

Specifically, initialize Base cardinality from defining (diff) element definition itself.
Do NOT inherit Base cardinality from parent element definition!
@wmrutten wmrutten added the bug label Jul 23, 2019
@wmrutten wmrutten self-assigned this Jul 23, 2019
@wmrutten wmrutten changed the title R4 SnapshotGenerator: Fix ElementDefinition.Base for newly introduced elements SnapshotGenerator: Fix ElementDefinition.Base for newly introduced elements Aug 6, 2019
@wmrutten wmrutten changed the title SnapshotGenerator: Fix ElementDefinition.Base for newly introduced elements R4 SnapshotGenerator: Fix ElementDefinition.Base for newly introduced elements Aug 6, 2019
wmrutten added a commit that referenced this issue Aug 22, 2019
@wmrutten
fix: #1053 R4 SnapshotGenerator: Fix Base cardinality for new elements
5f0a38f
wmrutten added a commit that referenced this issue Aug 29, 2019
@wmrutten
fix: #1053 R4 SnapshotGenerator: Fix Base cardinality for new elements
0648d44
@cknaap
Copy link
Member

cknaap commented Sep 16, 2019

It looks like this is merged into develop1.x/r4, so therefore putting it into the Sprint 2019.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wmrutten wmrutten

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cknaap @wmrutten @marcovisserFurore