STU3: Do not dispose of a shared HttpMessageHandler passed into the constructor #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…posed when it is done with it. # Conflicts: # src/Hl7.Fhir.Core.Tests/Rest/FhirClientTests.cs
…sion that includes the default parameter for the disposeHandler (even though we pass it throuth)
marcovisserFurore
changed the title
mmsmits
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating the new
HttpClientinside the constructor indicate that if it is a shared MessageHandler and therefore that it should not be disposing it when it is finished with it.As the change in the common lib has a default parameter this is not a truly breaking change, and in the R4 (version level) functionality the public surface has not changed this is not tagged as a breaking change.
Related issues
Resolves #2029
Testing
The unit test
CallsCallbacksHttpClientwas used to verify this functionality, as it fails when the fix is not applied.FirelyTeam Checklist