Support providing the HttpClient direct to the FhirClient #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…just the HttpClientHandler (as another alternative) This then supports creating unit tests as described here for webapi based projects https://www.hanselman.com/blog/minimal-apis-in-net-6-but-where-are-the-unit-tests
marcovisserFurore
requested changes
Apr 22, 2022
|
Made the changes as requested @marcovisserFurore |
marcovisserFurore
requested changes
Apr 22, 2022
src/Hl7.Fhir.Core/Rest/FhirClient.cs
Outdated
| /// If the endpoint does not end with a slash (/), it will be added. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller |
There was a problem hiding this comment.
Suggested change
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller | |
| /// If the httpClient is provided then it must be disposed by the caller |
Suggested change
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller | |
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller |
src/Hl7.Fhir.Core/Rest/FhirClient.cs
Outdated
| /// </summary> | ||
| /// <remarks> | ||
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller | ||
| /// Only one of the messageHandler or httpClient can be provided |
There was a problem hiding this comment.
Suggested change
| /// Only one of the messageHandler or httpClient can be provided |
Suggested change
| /// Only one of the messageHandler or httpClient can be provided | |
| /// Only one of the messageHandler or httpClient can be provided |
src/Hl7.Fhir.Core/Rest/FhirClient.cs
Outdated
| /// </summary> | ||
| /// <remarks> | ||
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller | ||
| /// Only one of the messageHandler or httpClient can be provided |
There was a problem hiding this comment.
Suggested change
| /// Only one of the messageHandler or httpClient can be provided |
Suggested change
| /// Only one of the messageHandler or httpClient can be provided | |
| /// Only one of the messageHandler or httpClient can be provided |
src/Hl7.Fhir.Core/Rest/FhirClient.cs
Outdated
| #pragma warning disable CS0067 | ||
|
|
||
| /// <summary> | ||
| /// Creates a new client using a default endpoint | ||
| /// If the endpoint does not end with a slash (/), it will be added. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// If the messageHandler is provided then it must be disposed by the caller | ||
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller |
There was a problem hiding this comment.
Suggested change
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller | |
| /// If the messageHandler is provided then it must be disposed by the caller |
Suggested change
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller | |
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller |
src/Hl7.Fhir.Core/Rest/FhirClient.cs
Outdated
| #pragma warning disable CS0067 | ||
|
|
||
| /// <summary> | ||
| /// Creates a new client using a default endpoint | ||
| /// If the endpoint does not end with a slash (/), it will be added. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// If the messageHandler is provided then it must be disposed by the caller | ||
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller |
There was a problem hiding this comment.
Suggested change
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller | |
| /// If the messageHandler is provided then it must be disposed by the caller |
Suggested change
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller | |
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller |
src/Hl7.Fhir.Core/Rest/FhirClient.cs
Outdated
| #pragma warning disable CS0067 | ||
|
|
||
| /// <summary> | ||
| /// Creates a new client using a default endpoint | ||
| /// If the endpoint does not end with a slash (/), it will be added. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// If the messageHandler is provided then it must be disposed by the caller | ||
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller | ||
| /// Only one of the messageHandler or httpClient can be provided |
There was a problem hiding this comment.
Suggested change
| /// Only one of the messageHandler or httpClient can be provided |
Suggested change
| /// Only one of the messageHandler or httpClient can be provided | |
| /// Only one of the messageHandler or httpClient can be provided |
marcovisserFurore
approved these changes
Apr 26, 2022
src/Hl7.Fhir.Core/Rest/FhirClient.cs
Outdated
| /// If the endpoint does not end with a slash (/), it will be added. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller |
There was a problem hiding this comment.
Suggested change
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller | |
| /// If the httpClient is provided then it must be disposed by the caller |
Suggested change
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller | |
| /// If the messageHandler, or httpClient is provided then it must be disposed by the caller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support providing the HttpClient direct to the FhirClient instead of the HttpClientHandler (as another alternative)
This then supports creating unit tests as described here for webapi based projects
https://www.hanselman.com/blog/minimal-apis-in-net-6-but-where-are-the-unit-tests
Related issues
Resolves/Contributes to #2046 #2036 (may be able to now push the HttpClientFactory work to the callers, and not be required in the FirelySDK at all)
Testing
Additional unit test included (and also included in my server to verify that can unit test as shown)