Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented FHIR R5, version 5.0.0 #2422

Merged
merged 19 commits into from Apr 11, 2023
Merged

Conversation

marcovisserFurore
Copy link
Member

@marcovisserFurore marcovisserFurore commented Mar 29, 2023

Description

Implemented FHIR R5, version 5.0.0

To be discussed:

  • ConstraintSeverity (http://hl7.org/fhir/ValueSet/constraint-severity) (in Hl7.Fhir.Conformance) is moved from namespace Hl7.Fhir.Model to Hl7.Fhir.Model.ElementDefinition. Breaking change?
  • specification.zip is partly made by DownloadFhirBuildProfile.ps1. After generation I replaced extension-definitions.xml by a folder extensions with the content of the package hl7.fhir.uv.extensions.r5#1.0.0.tgz. Should we automate this process?
  • Script DownloadFhirBuildProfile.ps1 downloaded the careplan example and moved it to folder src\Hl7.Fhir.Specification.R5.Tests\TestData\validation\careplan-example-integrated.xml. This example was not correct and I manually downloaded the example from https://www.hl7.org/fhir/careplan.html. Should we automate this?
  • ele-1 is not in the condition of Element anymore for R5. Is that correct?
  • The following elements are getting a IsSummary attribute, while the definition does not define that:
    • ConceptMap.group.element.target.relationship
    • Contract.term.action.doNotPerform
    • List.entry.deleted
    • Questionnaire.item.enableWhen
      According to Gino this is implemented in codegen because of this JIRA issue. I made a change in codegen to have the old behavior back. Should we add a Jira ticket for that?

Result:

  • ConstraintSeverity has been moved back to namespace Hl7.Fhir.Model to prevent breaking changes
  • DownloadFhirBuildProfile.ps1 has been adjusted so that it downloads the extension package automatically and merge it into specification.zip.
  • The removal of condition ele-1 in Element is correct.

Related issues

Resolves #2418

FirelyTeam Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Mark the PR with the label breaking change when this PR introduces breaking changes

@marcovisserFurore marcovisserFurore marked this pull request as ready for review April 4, 2023 15:25
@mmsmits mmsmits self-requested a review April 6, 2023 12:33
@marcovisserFurore marcovisserFurore merged commit dd3cda1 into develop Apr 11, 2023
15 checks passed
@marcovisserFurore marcovisserFurore deleted the feature/2418-fhir-5.0.0 branch April 11, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement FHIR R5, version 5.0.0
2 participants