New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented FHIR R5, version 5.0.0 #2422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tent of the package hl7.fhir.uv.extensions.r5#1.0.0.tgz
…, because that file is not present anymore.
…te-Bindings.cs again.
mmsmits
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented FHIR R5, version 5.0.0
To be discussed:
ConstraintSeverity
(http://hl7.org/fhir/ValueSet/constraint-severity) (in Hl7.Fhir.Conformance) is moved from namespaceHl7.Fhir.Model
toHl7.Fhir.Model.ElementDefinition
. Breaking change?specification.zip
is partly made by DownloadFhirBuildProfile.ps1. After generation I replacedextension-definitions.xml
by a folderextensions
with the content of the packagehl7.fhir.uv.extensions.r5#1.0.0.tgz
. Should we automate this process?src\Hl7.Fhir.Specification.R5.Tests\TestData\validation\careplan-example-integrated.xml
. This example was not correct and I manually downloaded the example from https://www.hl7.org/fhir/careplan.html. Should we automate this?ele-1
is not in the condition ofElement
anymore for R5. Is that correct?IsSummary
attribute, while the definition does not define that:ConceptMap.group.element.target.relationship
Contract.term.action.doNotPerform
List.entry.deleted
Questionnaire.item.enableWhen
According to Gino this is implemented in codegen because of this JIRA issue. I made a change in codegen to have the old behavior back. Should we add a Jira ticket for that?
Result:
ConstraintSeverity
has been moved back to namespaceHl7.Fhir.Model
to prevent breaking changesDownloadFhirBuildProfile.ps1
has been adjusted so that it downloads the extension package automatically and merge it intospecification.zip
.ele-1
inElement
is correct.Related issues
Resolves #2418
FirelyTeam Checklist