chore: Synchronous web cache #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nchronous-web-cache # Conflicts: # lib/flagsmith-es/package.json # lib/flagsmith/package.json # lib/react-native-flagsmith/package.json
novakzaballa
approved these changes
Mar 28, 2024
async-storage.ts
Outdated
Comment on lines
8
to
9
| const data = localStorage.getItem(key); | ||
| return data || null |
There was a problem hiding this comment.
Should we wrap this in a try catch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web supports synchronous cache, this PR adjusts the SDK in the following ways
The previous behaviour happened to cause undesired behaviour on OpenFeature's react implementation open-feature/js-sdk#881. Essentially, getting AsyncStorage in Flagsmith.init is so quick there's a race condition between useEffect(Where change listeners are setup for hooks). We saw similar behaviour before and opted to use refs for setting up listeners.