fix: remove pagination from group summaries (#3090)

Flagsmith · Dec 4, 2023 · 1065ad0 · 1065ad0 · vercel · Dec 4, 2023
1 parent d301104
commit 1065ad0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/api/tests/unit/organisations/test_unit_organisations_views.py b/api/tests/unit/organisations/test_unit_organisations_views.py
@@ -1664,12 +1664,12 @@ def test_list_group_summaries(
     assert response.status_code == status.HTTP_200_OK
 
     response_json = response.json()
-    assert response_json["count"] == 2
-    assert response_json["results"][0] == {
+    assert len(response_json) == 2
+    assert response_json[0] == {
         "id": user_permission_group_1.id,
         "name": user_permission_group_1.name,
     }
-    assert response_json["results"][1] == {
+    assert response_json[1] == {
         "id": user_permission_group_2.id,
         "name": user_permission_group_2.name,
     }

diff --git a/api/users/views.py b/api/users/views.py
@@ -191,6 +191,11 @@ def get_queryset(self):
 
         return qs
 
+    def paginate_queryset(self, queryset: QuerySet) -> list[UserPermissionGroup] | None:
+        if self.action == "summaries":
+            return None
+        return super().paginate_queryset(queryset)
+
     def get_serializer_class(self):
         if self.action == "retrieve":
             return UserPermissionGroupSerializerDetail