Skip to content

Commit

Permalink
fix: Fix GitHub comment logic when flag state is updated from GHA
Browse files Browse the repository at this point in the history
  • Loading branch information
novakzaballa committed Jun 3, 2024
1 parent 40f6aa7 commit d290f53
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions api/integrations/github/github.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,27 +113,28 @@ def generate_body_comment(
segment_name: str | None = None,
) -> str:

is_update = (
event_type == GitHubEventType.FLAG_UPDATED.value
or event_type == GitHubEventType.FLAG_UPDATED_FROM_GHA
)
is_removed = event_type == GitHubEventType.FEATURE_EXTERNAL_RESOURCE_REMOVED.value
is_segment_override_deleted = (
event_type == GitHubEventType.SEGMENT_OVERRIDE_DELETED.value
)

if event_type == GitHubEventType.FLAG_DELETED.value:
return DELETED_FEATURE_TEXT % (name)
elif event_type == GitHubEventType.FLAG_UPDATED_FROM_GHA:
return FEATURE_UPDATED_FROM_GHA_TEXT % (name)

if is_removed:
return UNLINKED_FEATURE_TEXT % (name)

if is_segment_override_deleted and segment_name is not None:
return DELETED_SEGMENT_OVERRIDE_TEXT % (segment_name, name)

result = UPDATED_FEATURE_TEXT % (name) if is_update else LINK_FEATURE_TITLE % (name)
result = ""
if event_type == GitHubEventType.FLAG_UPDATED.value:
result = UPDATED_FEATURE_TEXT % (name)
elif event_type == GitHubEventType.FLAG_UPDATED_FROM_GHA.value:
result = FEATURE_UPDATED_FROM_GHA_TEXT % (name)
else:
result = LINK_FEATURE_TITLE % (name)

last_segment_name = ""
if len(feature_states) > 0 and not feature_states[0].get("segment_name"):
result += FEATURE_TABLE_HEADER
Expand Down

0 comments on commit d290f53

Please sign in to comment.