Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement/api-audit #1112

Merged
merged 6 commits into from
May 16, 2022
Merged

improvement/api-audit #1112

merged 6 commits into from
May 16, 2022

Conversation

dabeeeenster
Copy link
Contributor

@dabeeeenster dabeeeenster commented May 13, 2022

Runs pip-audit once a day to check for security issues in dependencies

@dabeeeenster dabeeeenster added the api Issue related to the REST API label May 13, 2022
@matthewelwell
Copy link
Contributor

Is this instead of dependabot then?

@dabeeeenster
Copy link
Contributor Author

No it's in addition.

@matthewelwell
Copy link
Contributor

No it's in addition.

... can you explain why we need both? Looks like this is checking dev dependencies as well perhaps? But then surely we don't need dependabot. Maybe dependabot is good from a visibility point of view?

@dabeeeenster
Copy link
Contributor Author

Dependabot only runs once a week AFAIK. pip-audit is backed by Google and appears to be the new standard for python scanning. We should scan dev dependencies as their code runs on our machines!

@matthewelwell
Copy link
Contributor

Everything you're saying seems to suggest we should just use this and turn dependabot off then?

@dabeeeenster
Copy link
Contributor Author

Yeah we could do - but tbh I don't see what harm there is running both?

@matthewelwell
Copy link
Contributor

Probably none, yeah, but it's good to understand what the differences are. Let's go with both and see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants