fix first creation of segment in self-hosted context #1394
Merged
+11
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrettyWood
changed the title
PrettyWood
commented
Aug 18, 2022
| @@ -1,8 +1,15 @@ | |||
| import React, { Component } from 'react'; | |||
| import CreateSegmentModal from '../modals/CreateSegment'; | |||
| import TryIt from '../TryIt'; | |||
|
Ah this is a great quality of life change, thanks so much @PrettyWood |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a brand new instance of flagsmith in self-hosted environment, I couldn't create a segment. This is because I didn't set the
segment_operatorsremote config value.But this was not explained directly in the product. This is a proposition to fix this behavior
closes #1354
BEFORE
AFTER