Fix/edge identity/remove deleted features #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check and Update identity document if deleted feature exists in the identity document before processing it
api/tests/integration/edge_api/identities/test_edge_identity_featurestates_viewset.py
Outdated
Show resolved
Hide resolved
api/tests/integration/edge_api/identities/test_edge_identity_featurestates_viewset.py
Show resolved
Hide resolved
api/edge_api/identities/views.py
Outdated
| identity_feature_names = {fs.feature.name for fs in identity.identity_features} | ||
| if not identity_feature_names.issubset(valid_feature_names): | ||
| identity.prune_features(valid_feature_names) | ||
| sync_identity_document.delay(args=(build_identity_dict(identity),)) |
There was a problem hiding this comment.
I think we'd be better off just sending the identity id or composite key (depending on what we have available here )to the task and grabbing the identity out of the database in the task. That should avoid any issues with serialization of task arguments (and remove the need for the DjangoJSON encoder that you added).
It adds another read to the database in the task code but I think it will be cleaner overall.
There was a problem hiding this comment.
Yeah, that makes sense
api/task_processor/models.py
Outdated
| @@ -84,7 +85,7 @@ def kwargs(self) -> typing.Dict[str, typing.Any]: | |||
| @staticmethod | |||
| def _serialize_data(data: typing.Any): | |||
| # TODO: add datetime support if needed | |||
| return json.dumps(data) | |||
| return json.dumps(data, cls=DjangoJSONEncoder) | |||
There was a problem hiding this comment.
As above, I don't think we should need this?
api/tests/integration/edge_api/identities/test_edge_identity_featurestates_viewset.py
Show resolved
Hide resolved
matthewelwell
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.