Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new permissions for creating and approve change requests #1452

Merged
merged 5 commits into from
Sep 23, 2022

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Sep 14, 2022

Adds 2 new permissions to the schema: CREATE_CHANGE_REQUEST and APPROVE_CHANGE_REQUEST.

Users with UPDATE_FEATURE_STATE permissions are given both permissions by default to maintain current behaviour.

Note: this PR simply creates the permissions - they are consumed in endpoints in the flagsmith-workflows repository.

@matthewelwell matthewelwell force-pushed the feature/create-change-request-permissions branch from f78419c to aaba12c Compare September 14, 2022 13:07
@matthewelwell matthewelwell changed the title WIP: Add new permissions for creating and approve change requests Add new permissions for creating and approve change requests Sep 22, 2022
Copy link
Member

@gagantrivedi gagantrivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have some idea about how much time is applying the migration is going to take? I am assuming user table is not that big?

@matthewelwell matthewelwell merged commit 85fa6da into main Sep 23, 2022
@matthewelwell matthewelwell deleted the feature/create-change-request-permissions branch September 23, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants