-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/feature name validation #1778
Conversation
# Conflicts: # frontend/web/components/pages/ProjectSettingsPage.js
Uffizzi Preview |
Using this PR as a place to put this comment but I feel like this is an API issue more than a FE issue. I tested this using the regex string The question, however, is whether we want to automatically wrap the regex string in Also, I noticed that there is an extra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be nice, as an improvement to add a 'tester' input next to the input on the project settings page. Not essential but it would be nice.
Added |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingAdding RegEx Validation
feature-name-regex.mov
Only allowing valid RegEx's