Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSON references #1785

Merged
merged 7 commits into from
Jan 3, 2023
Merged

Add JSON references #1785

merged 7 commits into from
Jan 3, 2023

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?

Changes

  • Updates account settings to new tabbed style
  • Adds account setting "Show JSON References"
    image
  • Every page that has entities will show JSON with the ability to condense to just IDs
    image

@kyle-ssg kyle-ssg linked an issue Dec 19, 2022 that may be closed by this pull request
UI: show UUID of objects #1740
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2022 •
edited

Uffizzi Preview deployment-9303 was deleted.

@kyle-ssg kyle-ssg changed the title Add JSON references WIP: Add JSON references Dec 19, 2022
@kyle-ssg kyle-ssg changed the title WIP: Add JSON references Add JSON references Dec 19, 2022
@kyle-ssg
Merge branch 'main' into chores/json_view
87c3536 
# Conflicts:
#	frontend/web/components/modals/CreateFlag.js
#	frontend/web/components/pages/AccountSettingsPage.js
matthewelwell
matthewelwell approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. Looks good otherwise.

frontend/web/components/pages/FeaturesPage.js Outdated
renderFooter={()=>(
<>
<JSONReference className="mx-2 mt-4" showNamesButton title={"Features"} json={projectFlags}/>
<JSONReference className="mx-2" title={"Feature Values"} json={environmentFlags && Object.values(environmentFlags)}/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're using "Feature State" in the detail view of the feature, I suggest we use "Feature States" here too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep done

@kyle-ssg kyle-ssg merged commit 4cde8ce into main Jan 3, 2023
@kyle-ssg kyle-ssg deleted the chores/json_view branch January 3, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@dabeeeenster dabeeeenster Awaiting requested review from dabeeeenster

@gagantrivedi gagantrivedi Awaiting requested review from gagantrivedi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: show UUID of objects
2 participants
@kyle-ssg @matthewelwell