-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add view_identities permission #1787
Conversation
Uffizzi Preview |
It seems like this has had an effect on users with VIEW_ENVIRONMENT permissions from viewing Change Requests? To reproduce:
This might be unrelated to this PR but I've tested and it doesn't happen in production or staging. |
The above is unrelated to this PR - it's caused by the fact that the preview environment is built without the change request views (as they are contained in a separate private repository and bundled into the application at build time for SaaS / private cloud build workflows). |
In testing this, I've noticed a few issues:
|
# Conflicts: # frontend/web/components/modals/CreateFlag.js # frontend/web/components/pages/UserPage.js # frontend/web/components/pages/UsersPage.js
…ith/flagsmith into chores/view_identities_permission
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but I've created #1819 to track issue related to point 3 above.
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingChanges
Assuming the view_identities_permission feature is enabled: