Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input validation #1820

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Input validation #1820

merged 1 commit into from
Jan 4, 2023

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Jan 3, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?

Changes

  • Improved input success / invalid feedback

image

@kyle-ssg kyle-ssg linked an issue Jan 3, 2023 that may be closed by this pull request
Regex test input needs better feedback #1817
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Uffizzi Preview Environment

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/1820

⚙️ Updating now by workflow run 3831453096.

What is Uffizzi? Learn more

@kyle-ssg kyle-ssg merged commit 10d8854 into main Jan 4, 2023
@kyle-ssg kyle-ssg deleted the chores/improve_input_validation branch January 4, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabeeeenster dabeeeenster dabeeeenster approved these changes

@matthewelwell matthewelwell Awaiting requested review from matthewelwell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regex test input needs better feedback
2 participants
@kyle-ssg @dabeeeenster