Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(audit/models): trigger sse messages correctly #2179

Merged
merged 12 commits into from
May 22, 2023
Merged

fix(audit/models): trigger sse messages correctly #2179

merged 12 commits into from
May 22, 2023

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented May 3, 2023 •
edited

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?

Changes

Update update_environments_updated_at method to trigger SSE messages for every type of audit log apart from change request

How did you test this code?

Adds unit test cases

@vercel
Copy link

vercel bot commented May 3, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 11:22am

@gagantrivedi gagantrivedi temporarily deployed to production May 3, 2023 11:06 — with GitHub Actions Inactive
@gagantrivedi gagantrivedi temporarily deployed to staging May 3, 2023 11:06 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023 •
edited

Production preview deployment: > Success! https://flagsmith-fix-environment-updated-at.vercel.app now points to https://flagsmith-frontend-production-7g2dywtwt-flagsmith.vercel.app [2s]

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023 •
edited

Staging preview deployment: > Success! https://flagsmith-staging-fix-environment-updated-at.vercel.app now points to https://flagsmith-frontend-staging-gwgi51ovp-flagsmith.vercel.app [1s]

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023 •
edited

Uffizzi Preview deployment-24187 was deleted.

@gagantrivedi gagantrivedi temporarily deployed to production May 3, 2023 12:58 — with GitHub Actions Inactive
@gagantrivedi gagantrivedi temporarily deployed to staging May 3, 2023 12:58 — with GitHub Actions Inactive
@gagantrivedi gagantrivedi requested a deployment to production May 3, 2023 15:28 — with GitHub Actions Abandoned
@gagantrivedi gagantrivedi requested a deployment to staging May 3, 2023 15:28 — with GitHub Actions Abandoned
matthewelwell
matthewelwell reviewed May 3, 2023
View reviewed changes
api/audit/models.py Outdated Show resolved Hide resolved
api/audit/models.py Outdated Show resolved Hide resolved
api/audit/signals.py Show resolved Hide resolved
api/audit/models.py Outdated Show resolved Hide resolved
@gagantrivedi gagantrivedi temporarily deployed to production May 8, 2023 07:34 — with GitHub Actions Inactive
@gagantrivedi gagantrivedi temporarily deployed to staging May 8, 2023 07:34 — with GitHub Actions Inactive
@gagantrivedi gagantrivedi temporarily deployed to production May 8, 2023 08:18 — with GitHub Actions Inactive
@gagantrivedi gagantrivedi temporarily deployed to staging May 8, 2023 08:18 — with GitHub Actions Inactive
@gagantrivedi gagantrivedi temporarily deployed to production May 8, 2023 08:47 — with GitHub Actions Inactive
@gagantrivedi gagantrivedi temporarily deployed to staging May 8, 2023 08:47 — with GitHub Actions Inactive
@gagantrivedi gagantrivedi temporarily deployed to production May 9, 2023 08:13 — with GitHub Actions Inactive
@gagantrivedi gagantrivedi temporarily deployed to staging May 9, 2023 08:13 — with GitHub Actions Inactive
@gagantrivedi gagantrivedi temporarily deployed to production May 15, 2023 03:08 — with GitHub Actions Inactive
@gagantrivedi gagantrivedi temporarily deployed to staging May 15, 2023 03:08 — with GitHub Actions Inactive
gagantrivedi
gagantrivedi commented May 15, 2023
View reviewed changes
api/audit/models.py Outdated Show resolved Hide resolved
@matthewelwell matthewelwell mentioned this pull request May 15, 2023
Closed
matthewelwell
matthewelwell reviewed May 16, 2023
View reviewed changes
api/audit/migrations/0012_rename_skip_signals_auditlog_skip_subscriber.py Outdated Show resolved Hide resolved
api/audit/models.py Show resolved Hide resolved
api/audit/models.py Outdated Show resolved Hide resolved
matthewelwell
matthewelwell approved these changes May 17, 2023
View reviewed changes
api/audit/models.py Show resolved Hide resolved
@gagantrivedi gagantrivedi merged commit a52f3d4 into main May 22, 2023
12 checks passed
@gagantrivedi gagantrivedi deleted the fix/environment-updated-at branch May 22, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees

@matthewelwell matthewelwell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gagantrivedi @matthewelwell