Add specific permission to view audit logs #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewelwell
changed the title
|
Staging preview deployment: > Success! https://flagsmith-staging-2174-add-specific-permission-to.vercel.app now points to https://flagsmith-frontend-staging-9ex4zkb2g-flagsmith.vercel.app [1s] |
|
Uffizzi Preview |
|
Production preview deployment: > Success! https://flagsmith-2174-add-specific-permission-to-view-aud.vercel.app now points to https://flagsmith-frontend-production-mnoglawrw-flagsmith.vercel.app [1s] |
khvn26
approved these changes
May 15, 2023
|
@khvn26 I added all the typing as per your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a specific permission at the organisation level for viewing Audit Log records.
Note that as part of this, I've had to add a new endpoint since the current endpoint gets all of the audit log records for all organisations that a user belongs to.
The new endpoint is nested beneath the organisation so that it can be filtered accordingly and permissions can be applied. This will not affect the UI since the audit log is always currently shown in the context of a project (which
always belongs to a single organisation).
How did you test this code?
Added unit tests