Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix view / manage identity #2207

Merged
merged 2 commits into from
May 19, 2023
Merged

Fix view / manage identity #2207

merged 2 commits into from
May 19, 2023

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented May 15, 2023 •
edited

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?

Changes

  • Viewing a user page was based on manage_identities rather than view_identities
  • Editing a feature state for a user was based on manage_feature_states rather than manage_identities

A note whilst testing this, I had to remember this but manage identities does not include the ability to edit their feature states.

@vercel
Copy link

vercel bot commented May 15, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 5:58pm

@kyle-ssg kyle-ssg temporarily deployed to production May 15, 2023 17:17 — with GitHub Actions Inactive
@kyle-ssg kyle-ssg temporarily deployed to staging May 15, 2023 17:17 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2023 •
edited

Production preview deployment: > Success! https://flagsmith-fix-view-manage-identity.vercel.app now points to https://flagsmith-frontend-production-ad3nstmnh-flagsmith.vercel.app [1s]

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2023 •
edited

Uffizzi Preview deployment-25357 was deleted.

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2023 •
edited

Staging preview deployment: > Success! https://flagsmith-staging-fix-view-manage-identity.vercel.app now points to https://flagsmith-frontend-staging-r7k51uddn-flagsmith.vercel.app [1s]

@kyle-ssg kyle-ssg requested a deployment to production May 15, 2023 17:34 — with GitHub Actions Abandoned
@kyle-ssg kyle-ssg requested a deployment to staging May 15, 2023 17:34 — with GitHub Actions Abandoned
@kyle-ssg kyle-ssg temporarily deployed to production May 15, 2023 17:58 — with GitHub Actions Inactive
@kyle-ssg kyle-ssg temporarily deployed to staging May 15, 2023 17:58 — with GitHub Actions Inactive
@matthewelwell
Copy link
Contributor

@kyle-ssg so, just to clarify, the permissions from the FE perspective should now be as follows:

VIEW_IDENTITIES - users can list identities and click through to a read only view of an identity
MANAGE_IDENTITIES - users can edit an identity's traits
UPDATE_FEATURE_STATE - users can edit an identity's feature states (as well as all other feature states in the environment)

is that correct?

@dabeeeenster dabeeeenster added this to the Front End ToDo milestone May 17, 2023
@kyle-ssg
Copy link
Member Author

Yep @matthewelwell with the addition that manage identities can also create new ones too

@matthewelwell matthewelwell merged commit 2ecec6a into main May 19, 2023
12 checks passed
@matthewelwell matthewelwell deleted the fix/view_manage_identity branch May 19, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees

@kyle-ssg kyle-ssg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kyle-ssg @matthewelwell @dabeeeenster