Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group assignment model for Change Requests #2221

Conversation

matthewelwell
Copy link
Contributor

Changes

Adds the model needed to assign change requests to a group.

How did you test this code?

Added unit test for model method. Other tests will be added to flagsmith-workflows repository.

@vercel
Copy link

vercel bot commented May 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 5:27pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 5:27pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 5:27pm

@matthewelwell matthewelwell changed the title Add group assignment model Add group assignment model for Change Requests May 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 18, 2023

Uffizzi Preview deployment-25808 was deleted.

Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gagantrivedi gagantrivedi merged commit 74c4fff into main May 22, 2023
14 checks passed
@gagantrivedi gagantrivedi deleted the 2204-able-to-assign-a-change-request-to-a-user-without-permission-to-view-change-requests branch May 22, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Able to assign a change request to a user without permission to view change requests
3 participants