feat(integrations): Add support for slack integration #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagantrivedi
force-pushed
the
feat/github-83/slack-integration
branch
from
633a45d
to
b2b280b
Compare
gagantrivedi
changed the title
gagantrivedi
force-pushed
the
feat/github-83/slack-integration
branch
2 times, most recently
from
704199d
to
305d849
Compare
matthewelwell
requested changes
Oct 28, 2021
dabeeeenster
changed the title
gagantrivedi
force-pushed
the
feat/github-83/slack-integration
branch
from
3b21603
to
0f0da1b
Compare
matthewelwell
approved these changes
Dec 21, 2021
redirect the user to the given url after successful oauth
gagantrivedi
commented
Dec 21, 2021
gagantrivedi
requested review from
matthewelwell
and removed request for
matthewelwell
|
Requesting the review again because of redirect url |
matthewelwell
approved these changes
Dec 22, 2021
matthewelwell
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLACK_CLIENT_ID
SLACK_CLIENT_SECRET
To start the oath flow we make a get request to
https://{address}/api/v1/environments/<environment_key>/integrations/slack/oauth/
which redirects the user(after oauth) to our callback endpoint(with auth token)
The view set to configure a channel for an environment is hosted at:
/environments/{environment_api_key}/integrations/slack/
ps: you can use something like https://ngrok.com/ to test oauth callback
Open question:
where should we redirect the user after successful oauth.