Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sentry-FLAGSMITH-API-4FZ): fix PATCH for segments #4029

Merged
merged 1 commit into from
May 28, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented May 27, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

fix broken PATCH request to segments

How did you test this code?

Adds a unit test

Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 5:09am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 5:09am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 5:09am

Copy link

sentry-io bot commented May 27, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: api/segments/serializers.py

Function Unhandled Issue
validate AttributeError: 'NoneType' object has no attribute 'organisation' /api/v1/projects/{project_p...
Event Count: 7

Did you find this useful? React with a 👍 or 👎

Copy link
Contributor

github-actions bot commented May 27, 2024

Uffizzi Preview deployment-52276 was deleted.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (50cc369) to head (13d44fd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4029   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files        1145     1145           
  Lines       37295    37302    +7     
=======================================
+ Hits        35959    35966    +7     
  Misses       1336     1336           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 3c43bb8 May 28, 2024
24 checks passed
@gagantrivedi gagantrivedi deleted the fix/sentry-4FZ branch May 28, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants