Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use python3.11 as base image #4121

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Jun 6, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Because:
Changed in version 3.12: The deprecated keyfile and certfile parameters have been removed.
ref: https://docs.python.org/3/library/smtplib.html#smtplib.SMTP_SSL

How did you test this code?

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 9:53am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 9:53am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 9:53am

Because:
Changed in version 3.12: The deprecated keyfile and certfile parameters have
been removed.
ref: https://docs.python.org/3/library/smtplib.html#smtplib.SMTP_SSL
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Uffizzi Preview deployment-52707 was deleted.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (f0eae7b) to head (07e8ca5).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4121   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files        1149     1149           
  Lines       37596    37605    +9     
=======================================
+ Hits        36259    36268    +9     
  Misses       1337     1337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit 418e026 Jun 6, 2024
23 checks passed
@matthewelwell matthewelwell deleted the build/downgrade-to-py311 branch June 6, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants