Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: task processor settings tweaks #4126

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

matthewelwell
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Tweak the task processor retention settings to:

  1. reduce the retention period (only by 1 day as we want to limit the impact on the database that deleting multiple days would cause). We should ideally continue to decrement this number until we get down to 30.
  2. increase the batch size in which tasks are deleted so that it's not having to run as many batches when deleting tasks. We should ideally continue to increment this number until we get to 500,000.

How did you test this code?

Needs testing in production when the next scheduled task runs to delete tasks.

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jun 6, 2024 0:01am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jun 6, 2024 0:01am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jun 6, 2024 0:01am

@matthewelwell matthewelwell requested review from a team and khvn26 and removed request for a team June 6, 2024 12:01
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this!

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Uffizzi Preview deployment-52717 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit ea96db9 Jun 6, 2024
9 checks passed
@matthewelwell matthewelwell deleted the infra/task-processor-settings-tweaks branch June 6, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants