fix(proj/get_segment): fix n+1 queries for rules conditions #445
Conversation
Remove two level deep rules prefetching since we don't support that from the UI. Add code to prefetch conditions of the child rule as well
There was a problem hiding this comment.
@gagantrivedi I made a small tweak to the test and determined that your solution still wasn't quite right. I've added the required arguments back in and the tests are now passing.
Interestingly, if we remove the "rules__rules__conditions" argument we end up with 106 queries based on this (hyper unrealistic) test.
It actually should work since to fetch |
Remove two level deep rules prefetching since we don't support that
from the UI.
Add code to prefetch conditions of the child rule as well