Allow sentry-trace header in CORS restrictions #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way Sentry works in the browser is that it injects itself into the XMLHttpRequest function and adds a sentry-trace header there. This ends up causing calls to the Flagsmith api to fail. I think the proper way to do it is just allow the sentry flags to pass through Optionally just allow ALL headers. I am not sure why there are header restrictions in the first place.
dabeeeenster
requested review from
matthewelwell,
dabeeeenster and
gagantrivedi
|
@tm1000 can you make sure that your PRs have been correctly formatted using |
dabeeeenster
approved these changes
Nov 4, 2021
Merged
dabeeeenster
added a commit
that referenced
this pull request
Nov 4, 2021
* Update common.py (#449) The way Sentry works in the browser is that it injects itself into the XMLHttpRequest function and adds a sentry-trace header there. This ends up causing calls to the Flagsmith api to fail. I think the proper way to do it is just allow the sentry flags to pass through Optionally just allow ALL headers. I am not sure why there are header restrictions in the first place. * Black formatting Co-authored-by: Andrew Nagy <tm1000@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way Sentry works in the browser is that it injects itself into the XMLHttpRequest function and adds a sentry-trace header there. This ends up causing calls to the Flagsmith api to fail. I think the proper way to do it is just allow the sentry flags to pass through
Optionally just allow ALL headers. I am not sure why there are header restrictions in the first place.