Feat/GitHub 677/identity migration #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
gagantrivedi
force-pushed
the
feat/github-677/identity-migration
branch
from
1058e81
to
887b92a
Compare
| from .types import DynamoProjectMetadata | ||
|
|
||
|
|
||
| class DynamoProjectMetadataWrapper: |
There was a problem hiding this comment.
I feel like the logic in this wrapper can absorbed into the DynamoProjectMetadata dataclass itself? We can use a classmethod to get a given metadata record from dynamo and load it into the dataclass.
matthewelwell
requested changes
Feb 8, 2022
api/environments/dynamodb/tests/types/test_dynamodb_project_metadata.py
Outdated
Show resolved
Hide resolved
api/environments/dynamodb/tests/types/test_dynamodb_project_metadata.py
Outdated
Show resolved
Hide resolved
matthewelwell
approved these changes
Feb 8, 2022
gagantrivedi
added a commit
that referenced
this pull request
Feb 11, 2022
Add command to migrate identity to edge Add migrate identity to sales dashboard tests(command): add test for migrate_to_edge command * tests(sales-dashboard): Add tests for migrate identity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for migrating the identity data to dynamo db using the following two ways:
python manage.py migrate_to_edge <project_id>UI:
Also implements: #726
Deployment Notes: Create a dynamodb table with id(Number) as partition key and use it's name for
PROJECT_METADATA_TABLE_NAME_DYNAMOEnv vairable.