Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/cancellation date on dashboard #769

Merged
merged 7 commits into from
Feb 10, 2022
Merged

feature/cancellation date on dashboard #769

merged 7 commits into from
Feb 10, 2022

Conversation

dabeeeenster
Copy link
Contributor

  • fix(sales-dashboard-crash): only call dynamo if enabled
  • Surface cancellations

@dabeeeenster dabeeeenster linked an issue Feb 10, 2022 that may be closed by this pull request
Add cancellation date/status to sales dashboard #754
Closed
matthewelwell
matthewelwell approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one minor suggestion for improvement.

api/sales_dashboard/templates/sales_dashboard/home.html Outdated Show resolved Hide resolved
@dabeeeenster dabeeeenster merged commit 48cea08 into main Feb 10, 2022
@dabeeeenster dabeeeenster deleted the feature/cancellation-date-on-dashboard branch February 10, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@gagantrivedi gagantrivedi Awaiting requested review from gagantrivedi

Assignees

@matthewelwell matthewelwell

@gagantrivedi gagantrivedi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cancellation date/status to sales dashboard
3 participants
@dabeeeenster @matthewelwell @gagantrivedi