Hide gemcutter_key in gem env

git-svn-id: svn+ssh://rubyforge.org/var/svn/rubygems/trunk@2498 3d4018f9-ac1a-0410-99e9-8a154d859a19
Flameeyes · Apr 22, 2010 · 6b64042 · 6b64042
1 parent 20d8202
commit 6b64042
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -4,6 +4,8 @@
 
 	* lib/rubygems/commands/contents_command.rb:  Make --prefix the
 	  default as specified in --help.  Bug #27211 by Mamoru Tasaka.
+	* lib/rubygems/commands/environment_command.rb:  Hide gemcutter_key to
+	  for security.
 
 2010-04-21  Evan Phoenix <evan@fallingsnow.net>
 

diff --git a/lib/rubygems/commands/environment_command.rb b/lib/rubygems/commands/environment_command.rb
@@ -109,6 +109,7 @@ def execute
 
       out << "  - GEM CONFIGURATION:\n"
       Gem.configuration.each do |name, value|
+        value = value.gsub(/./, 'X') if name == 'gemcutter_key'
         out << "     - #{name.inspect} => #{value.inspect}\n"
       end
 

diff --git a/test/test_gem_commands_environment_command.rb b/test/test_gem_commands_environment_command.rb
@@ -12,6 +12,7 @@ def setup
   def test_execute
     orig_sources = Gem.sources.dup
     Gem.sources.replace %w[http://gems.example.com]
+    Gem.configuration['gemcutter_key'] = 'blah'
 
     @cmd.send :handle_options, %w[]
 
@@ -32,6 +33,7 @@ def test_execute
     assert_match %r|GEM PATHS:|, @ui.output
     assert_match %r|- #{Regexp.escape @gemhome}|, @ui.output
     assert_match %r|GEM CONFIGURATION:|, @ui.output
+    assert_match %r|"gemcutter_key" => "XXXX"|, @ui.output
     assert_match %r|:verbose => |, @ui.output
     assert_match %r|REMOTE SOURCES:|, @ui.output
     assert_equal '', @ui.error