Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test targets for Corellium #2051

Closed
bootstraponline opened this issue Jun 29, 2021 · 0 comments · Fixed by #2056
Closed

Test targets for Corellium #2051

bootstraponline opened this issue Jun 29, 2021 · 0 comments · Fixed by #2056
Assignees
@jan-goral
Labels
Corellium Feature P0

Comments

@bootstraponline
Copy link
Contributor

Author the user story for this feature

As an Android Engineer, I want to filter the tests that run so I can compare FTL to Corellium.

Describe the solution

Implement the test targets feature for the corellium backend. This is a blocker for going to production.

Describe alternatives considered

Not implementing this feature.
@jan-goral jan-goral self-assigned this Jun 29, 2021
This was referenced Jun 30, 2021
Closed
Merged
@mergify mergify bot closed this as completed in #2056 Jul 6, 2021
mergify bot pushed a commit that referenced this issue Jul 6, 2021
@jan-goral
feat: Test targets option for Corellium (#2056)
630d68a 
Fixes #2051

Requires #2055

Enchanted by #2062

## Changes

* Add test targets argument for filtering test cases.
* Add filtering option to Apk.ParseTestCases.
* Log AndroidTestPlan.Config on ExecuteTests start.
* Refactor `:tool:apk` module

## Test Plan
> How do we know the code works?

build flank
```shell
. .env
flankScripts assemble flank -d
```
and run 
```shell
flank corellium test android run -c="./test_configs/flank-corellium.yml"
```
using configuration
```yml
auth: "test_configs/corellium_auth.yml"
apks:
  - path: "test_artifacts/master/apk/app-debug.apk"
    tests:
      - path: "test_artifacts/master/apk/app-multiple-flaky-debug-androidTest.apk"
test-targets:
  - "package com.example.test_app.parametrized"
  - "notClass com.example.test_app.parametrized.EspressoParametrizedClassTestParameterized"
  - "package com.example.test_app.foo"
  - "class com.example.test_app.InstrumentedTest#test0"
max-test-shards: 3
```
As a results Flank should execute only test cases restricted by test targets.

## Checklist

- [x] Documented
- [x] Unit tested
- [x] Integrated with a filtering tool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jan-goral jan-goral

Labels
Corellium Feature P0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Test targets option for Corellium Flank/flank
2 participants
@bootstraponline @jan-goral