Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Test targets option for Corellium #2056

Merged
merged 5 commits into from Jul 6, 2021

Conversation

jan-goral
Copy link
Contributor

@jan-goral jan-goral commented Jun 30, 2021

Fixes #2051

Requires #2055

Enchanted by #2062

Changes

  • Add test targets argument for filtering test cases.
  • Add filtering option to Apk.ParseTestCases.
  • Log AndroidTestPlan.Config on ExecuteTests start.
  • Refactor :tool:apk module

Test Plan

How do we know the code works?

build flank

. .env
flankScripts assemble flank -d

and run

flank corellium test android run -c="./test_configs/flank-corellium.yml"

using configuration

auth: "test_configs/corellium_auth.yml"
apks:
  - path: "test_artifacts/master/apk/app-debug.apk"
    tests:
      - path: "test_artifacts/master/apk/app-multiple-flaky-debug-androidTest.apk"
test-targets:
  - "package com.example.test_app.parametrized"
  - "notClass com.example.test_app.parametrized.EspressoParametrizedClassTestParameterized"
  - "package com.example.test_app.foo"
  - "class com.example.test_app.InstrumentedTest#test0"
max-test-shards: 3

As a results Flank should execute only test cases restricted by test targets.

Checklist

  • Documented
  • Unit tested
  • Integrated with a filtering tool

@bootstraponline
Copy link
Contributor

let's update the documentation in https://github.com/Flank/flank/blob/master/docs/flank_corellium.md to show that test targets is supported

@jan-goral jan-goral linked an issue Jul 1, 2021 that may be closed by this pull request
@jan-goral jan-goral force-pushed the 2051_Test_targets_for_Corellium branch 2 times, most recently from a3380f8 to dd61d58 Compare July 2, 2021 15:05
@jan-goral jan-goral marked this pull request as ready for review July 2, 2021 15:43
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

Timestamp: 2021-07-06 13:09:53
Buildscan url for ubuntu-workflow run 1004479270
https://gradle.com/s/623wao3fuc2wm

@bootstraponline bootstraponline force-pushed the 2051_Test_targets_for_Corellium branch 2 times, most recently from e3e367a to acc8f74 Compare July 5, 2021 12:06
@jan-goral jan-goral force-pushed the 2051_Test_targets_for_Corellium branch from acc8f74 to 5815ee3 Compare July 6, 2021 08:37
Add filtering option to Apk.ParseTestCases.
Log AndroidTestPlan.Config on ExecuteTests start.
Refactor :tool:apk module
TODO: integrate with test filtering tool
@bootstraponline bootstraponline force-pushed the 2051_Test_targets_for_Corellium branch from 5815ee3 to d1228b9 Compare July 6, 2021 13:02
@mergify mergify bot merged commit 630d68a into master Jul 6, 2021
@mergify mergify bot deleted the 2051_Test_targets_for_Corellium branch July 6, 2021 14:06
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameterized tests support Test targets for Corellium
4 participants