-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
num-flaky-test-attempts reset to 0 and renamed to flaky-test-attempts #603
Comments
Thanks for the report! I'll try to look into this once I have some time. |
Howdy @bootstraponline, is there any news on when a fix for this might be available? Now that we've switched to x86 devices we're seeing quite a few more flaky tests. Many are just intermittently flaky and this option would be extremely helpful. |
hey, sorry for the lack of response. I've transitioned to a new role that has been consuming all my time. I will try and get this prioritized on the weekend. |
Sorry for the delay.
https://github.com/TestArmada/flank/releases/tag/v8.0.0 If you're still seeing the issue in Flank v8 let me know and I'll fix it quickly. |
I confirmed this is working as expected in Flank v8.0.1. |
works great! |
Awesome! |
I'm setting a value of 3 for num-flaky-test-attempts in our config file:
https://github.com/mozilla-mobile/fenix/blob/disable-findinpage-test/automation/taskcluster/androidTest/flank-x86.yml#L26
However when we run our tests, it looks like this param is not being handled properly as the config is resetting to the old key name and the value is being reset from 3 to 0
flaky-test-attempts: 0
see:
#595
The text was updated successfully, but these errors were encountered: