Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Change Firebase device for UI tests #5620

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Change Firebase device for UI tests #5620

merged 1 commit into from
Sep 27, 2019

Conversation

rpappalax
Copy link
Contributor

@rpappalax rpappalax commented Sep 26, 2019

This PR attempts to address test flakiness in the findInPage test which is probably restricted to a virtual device irregularity. Also, moving num-flaky-test-attempts to proper config position although NOTE: this appears to be busted at the moment. I've filed:
Flank/flank#603

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@rpappalax rpappalax added the eng:automation Build automation, Continuous integration, .. label Sep 26, 2019
@rpappalax rpappalax requested review from AaronMT and removed request for AaronMT September 26, 2019 19:40
@rpappalax rpappalax added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Sep 26, 2019
@codecov-io
Copy link

codecov-io commented Sep 26, 2019

Codecov Report

Merging #5620 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5620   +/-   ##
=========================================
  Coverage     14.02%   14.02%           
  Complexity      308      308           
=========================================
  Files           256      256           
  Lines         10490    10490           
  Branches       1522     1522           
=========================================
  Hits           1471     1471           
  Misses         8902     8902           
  Partials        117      117

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de93b05...5b72095. Read the comment docs.

@rpappalax rpappalax changed the title Temporarily disable findInPage UI test Change Firebase device for UI tests Sep 26, 2019
@rpappalax rpappalax removed the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Sep 26, 2019
@sblatz sblatz merged commit 93558f0 into master Sep 27, 2019
@rpappalax rpappalax deleted the disable-findinpage-test branch September 27, 2019 22:05
sblatz pushed a commit to sblatz/fenix that referenced this pull request Sep 30, 2019
sblatz pushed a commit to sblatz/fenix that referenced this pull request Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:automation Build automation, Continuous integration, ..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants