Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Added documentation about handling #1374 issue #1380

Merged
merged 1 commit into from
Dec 7, 2020
Merged

docs: Added documentation about handling #1374 issue #1380

merged 1 commit into from
Dec 7, 2020

Conversation

piotradamczyk5
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 commented Dec 7, 2020 •
edited
Loading

Fixes #1374

Test Plan

How do we know the code works?

This is documentation about the #1374 issue

Checklist

  • Documented

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2020 •
edited
Loading

Timestamp: 2020-12-07 16:23:57
Buildscan url for ubuntu-workflow run 406257198
https://gradle.com/s/jkwvj4gh3fyma

@github-actions github-actions bot added the Bug label Dec 7, 2020
adamfilipow92
adamfilipow92 approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understandable and looks good! 👍

@mergify mergify bot merged commit 5081a69 into master Dec 7, 2020
@mergify mergify bot deleted the #1374_test_sharding_butg_docs branch December 7, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sloox Sloox Sloox approved these changes

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@zuziaka zuziaka Awaiting requested review from zuziaka

@bootstraponline bootstraponline Awaiting requested review from bootstraponline

@jan-goral jan-goral Awaiting requested review from jan-goral

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

Assignees

@piotradamczyk5 piotradamczyk5

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

null cannot be used as parameter value in parameterized tests
3 participants
@piotradamczyk5 @Sloox @adamfilipow92