Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix integration tests on CI. #1410

Merged
merged 6 commits into from
Dec 18, 2020
Merged

fix: Fix integration tests on CI. #1410

merged 6 commits into from
Dec 18, 2020

Conversation

adamfilipow92
Copy link
Contributor

Fixes #1408

Test Plan

How do we know the code works?

All IT should pass locally and on CI

Checklist

  • Integration tests updated

@adamfilipow92 adamfilipow92 self-assigned this Dec 17, 2020
@github-actions github-actions bot added Bug IT_Failed Issue created by GH bot when IT fails on master labels Dec 17, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2020 •
edited
Loading

Timestamp: 2020-12-18 14:43:00
Buildscan url for ubuntu-workflow run 430670977
https://gradle.com/s/ujudaee6oi7i4

@codecov-io
Copy link

codecov-io commented Dec 17, 2020 •
edited
Loading

Codecov Report

Merging #1410 (ee005bd) into master (2b84392) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1410   +/-   ##
=========================================
  Coverage     77.34%   77.34%           
  Complexity      719      719           
=========================================
  Files           250      250           
  Lines          4834     4834           
  Branches        922      922           
=========================================
  Hits           3739     3739           
  Misses          596      596           
  Partials        499      499

@piotradamczyk5 piotradamczyk5 self-assigned this Dec 17, 2020
@piotradamczyk5
Copy link
Contributor

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Dec 17, 2020

Command rebase: success

Branch has been successfully rebased

@piotradamczyk5
Copy link
Contributor

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2020 •
edited
Loading

Integration tests failed, you could see results here

piotradamczyk5
piotradamczyk5 suggested changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for fix all tests

@adamfilipow92
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2020 •
edited
Loading

Integration tests failed, you could see results here

@adamfilipow92
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2020 •
edited
Loading

Integration tests failed, you could see results here

@pawelpasterz
Copy link
Contributor

I think we should run IT again once #1413 is merged (and this PR is rebased)

@piotradamczyk5
Copy link
Contributor

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2020 •
edited
Loading

Integration tests failed, you could see results here

@adamfilipow92
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2020 •
edited
Loading

Integration tests succeed, you could see results here

piotradamczyk5
piotradamczyk5 approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@piotradamczyk5 piotradamczyk5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Say no more

Integration tests succeed, you could see results here

@adamfilipow92 adamfilipow92 changed the title fix: Fix integration tests on CI fix: Fix integration tests on CI. Dec 18, 2020
@piotradamczyk5
Copy link
Contributor

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Dec 18, 2020

Command rebase: success

Branch already up to date

@mergify mergify bot merged commit 541f21c into master Dec 18, 2020
@mergify mergify bot deleted the fix-gameloop-integration-tests branch December 18, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sloox Sloox Sloox approved these changes

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@zuziaka zuziaka Awaiting requested review from zuziaka

@pawelpasterz pawelpasterz Awaiting requested review from pawelpasterz

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@adamfilipow92 adamfilipow92

@piotradamczyk5 piotradamczyk5

Labels
Bug IT_Failed Issue created by GH bot when IT fails on master Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Full Suite integration tests failed on master
5 participants
@adamfilipow92 @codecov-io @piotradamczyk5 @pawelpasterz @Sloox