Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update compare files in IT #1631

Merged
merged 2 commits into from
Feb 25, 2021
Merged

fix: Update compare files in IT #1631

merged 2 commits into from
Feb 25, 2021

Conversation

pawelpasterz
Copy link
Contributor

Fixes #1628

Test Plan

How do we know the code works?

  1. Integration tests pass

@pawelpasterz pawelpasterz self-assigned this Feb 25, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2021 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@pawelpasterz
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2021 •
edited
Loading

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status failure - Build scan: https://gradle.com/s/c2y6c66zrnd3a
Linux status failure - Build scan: https://gradle.com/s/h7upcda52z6hs
Workflow run https://github.com/Flank/flank/actions/runs/598609183

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2021 •
edited
Loading

Timestamp: 2021-02-25 09:35:47
Buildscan url for ubuntu-workflow run 598963606
https://gradle.com/s/rguoxc4fis2su

@pawelpasterz
Copy link
Contributor Author

Tests fail due to quota limit exceeded 🙄 But those which do not require actual test run, pass https://scans.gradle.com/s/c2y6c66zrnd3a/tests

Sloox
Sloox approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Didnt realize it would have an effect.

@pawelpasterz
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2021 •
edited
Loading

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/oueqkzfkk3uuc
Linux Build scan: https://gradle.com/s/ko6a56awxsupg
Workflow run https://github.com/Flank/flank/actions/runs/598768885

@Sloox Sloox enabled auto-merge (squash) February 25, 2021 09:26
@Sloox Sloox disabled auto-merge February 25, 2021 09:30
@Sloox
Copy link
Contributor

Sloox commented Feb 25, 2021

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2021 •
edited
Loading

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/ksfjvztduqkze
Linux Build scan: https://gradle.com/s/dk7hqfsjcbudg
Workflow run https://github.com/Flank/flank/actions/runs/598964204

@pawelpasterz
Copy link
Contributor Author

Missing URL for windows is a known issue gradle/gradle-build-action#30

@pawelpasterz pawelpasterz merged commit a17777c into master Feb 25, 2021
@pawelpasterz pawelpasterz deleted the 1628-follow-up branch February 25, 2021 11:53
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sloox Sloox Sloox approved these changes

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@adamfilipow92 adamfilipow92 Awaiting requested review from adamfilipow92

@zuziaka zuziaka Awaiting requested review from zuziaka

@jan-goral jan-goral Awaiting requested review from jan-goral

Assignees

@Sloox Sloox

@pawelpasterz pawelpasterz

Labels
Bug Snake 🐍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawelpasterz @Sloox @piotradamczyk5