Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix missing junit report in legacy mode #1807

Merged
merged 2 commits into from
Apr 19, 2021

Conversation

adamfilipow92
Copy link
Contributor

@adamfilipow92 adamfilipow92 commented Apr 14, 2021

Fixes #1778

Test Plan

How do we know the code works?

All tests should pass, when using android tests with legacy mode Flank should generate JUnitReport in the results directory, performance metrics file should be created.

This pr is a revert of @piotradamczyk5 change related to performanceMetrics.json creation. I was checking this feature and still works fine.

To test if performanceMetrics.json are created:

  1. Run any test case with a physical device for e.g.
device:
    - model: starqlteue
      version: 26
  1. Check if the Flank output contains a line about uploading performanceMetrics.json to gcs
 Uploading [performanceMetrics.json] to https://console.developers.google.com/storage/browser/test-lab-v9cn46bb990nx-kz69ymd4nm9aq/2021-04-19_07-59-02.195180_AbIK/matrix_0/...
  1. Check if local matrix directories contain performanceMetrics.json

  2. Run the same Flank configuration on the current master and compare performanceMetrics.json.

Test results

gcloud:
  app: ./test_runner/src/test/kotlin/ftl/fixtures/tmp/apk/app-debug.apk
  test: ./test_runner/src/test/kotlin/ftl/fixtures/tmp/apk/app-single-success-debug-androidTest.apk
  device:
    - model: starqlteue
      version: 26

flank:
  disable-sharding: true
  output-report: json
  1. performanceMetrics.json from this branch link

  2. performanceMetrics.json from current master link

Checklist

  • Integration tests updated

@adamfilipow92 adamfilipow92 self-assigned this Apr 14, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2021

Timestamp: 2021-04-19 09:44:28
Buildscan url for ubuntu-workflow run 763077017
https://gradle.com/s/pjinrvsuxk6uk

@adamfilipow92
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2021

Integration tests failed ❌
Windows status failure - Build scan:
MacOS status success - Build scan: https://gradle.com/s/lzrbvp4f2fvpc
Linux status success - Build scan: https://gradle.com/s/n3rmq4aiub3q4
Workflow run https://github.com/Flank/flank/actions/runs/748092014

@adamfilipow92
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2021

Integration tests succeed for all OSes ✅
Windows Build scan:
MacOS Build scan: https://gradle.com/s/p3zmyioiqydmk
Linux Build scan:
Workflow run https://github.com/Flank/flank/actions/runs/752235163

@piotradamczyk5 piotradamczyk5 self-requested a review April 15, 2021 15:06
@adamfilipow92 adamfilipow92 marked this pull request as ready for review April 15, 2021 15:06
@bootstraponline bootstraponline force-pushed the 1778-fix-missing-junit-report branch 2 times, most recently from 8382809 to 0b37496 Compare April 19, 2021 09:28
@adamfilipow92
Copy link
Contributor Author

@flank-it

@github-actions
Copy link
Contributor

Integration tests were triggered at 2021-04-19 10:41:22, you can track progress here

@mergify mergify bot merged commit f5f61c1 into master Apr 19, 2021
@mergify mergify bot deleted the 1778-fix-missing-junit-report branch April 19, 2021 11:17
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing JUnitReport with legacy mode
3 participants