-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlexMeasures CLI complains about an asset being added to an account if there is already a public asset with the same name #728
Comments
nhoening
added a commit
that referenced
this issue
Jun 15, 2023
… special case for public assets (#728)# Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Flix6x
pushed a commit
that referenced
this issue
Jun 15, 2023
… special case for public assets (#728)# Signed-off-by: Nicolas Höning <nicolas@seita.nl>
nhoening
added a commit
that referenced
this issue
Jun 15, 2023
* feat: Allow adding public assets through the CLI Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: changelog entry Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: CLI changelog entry Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: update help string Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: add missing CLI changelog entries Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: add release date Signed-off-by: F.N. Claessen <felix@seita.nl> * add warning if a public asset has been created Signed-off-by: Nicolas Höning <nicolas@seita.nl> * fix wrong query setup in validate_name_is_unique_in_account, also add special case for public assets (#728)# Signed-off-by: Nicolas Höning <nicolas@seita.nl> * Revert "fix wrong query setup in validate_name_is_unique_in_account, also add special case for public assets (#728)#" This reverts commit ba278b1. * The `and` statement was not working as intended. Also, using `first` is more robust against duplicate asset names already being present in the database. Signed-off-by: F.N. Claessen <felix@seita.nl> * Revert "The `and` statement was not working as intended. Also, using `first` is more robust against duplicate asset names already being present in the database." This reverts commit 64b9632. * fix wrong query setup in validate_name_is_unique_in_account, also add special case for public assets (#728)# Signed-off-by: Nicolas Höning <nicolas@seita.nl> * Using first is more robust against duplicate asset names already being present in the database. Signed-off-by: F.N. Claessen <felix@seita.nl> * Simplify if-statement Signed-off-by: F.N. Claessen <felix@seita.nl> * Note the user-facing CLI option in the help string Signed-off-by: F.N. Claessen <felix@seita.nl> --------- Signed-off-by: F.N. Claessen <felix@seita.nl> Signed-off-by: Nicolas Höning <nicolas@seita.nl> Co-authored-by: Nicolas Höning <nicolas@seita.nl>
Fixed by #727 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I found that FM complains about an asset being added to an account if there is already a public asset with the same name (I added two debug logs for clarity, "New asset data:" and "Found asset:"):
I feel that the query in
data/schemas/generic_assets.py
(line 52) looks okay, currently I don't know why the public asset is found:Originally posted by @nhoening in #727 (comment)
The text was updated successfully, but these errors were encountered: